Rename snmptrapd command line program to navtrapd
#2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name conflicts with Net-SNMP's `snmptrapd` program. The Net-SNMP utilities are a very common companion to a NAV install, so the struggle is real.
Reference the new name of the command line program
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.10.x #2926 +/- ##
=======================================
Coverage 60.27% 60.27%
=======================================
Files 602 602
Lines 44099 44099
=======================================
Hits 26580 26580
Misses 17519 17519 ☔ View full report in Codecov by Sentry. |
stveit
reviewed
May 27, 2024
Simply because it's more work (than a simple bugfix) :) |
hmpf
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2882
This really just renames the installed "binary", it does not change the internal module names or references otherwise.